We use these services and cookies to improve your user experience. You may opt out if you wish, however, this may limit some features on this site.

Please see our statement on Data Privacy.

Zendesk (Helpdesk and Chat)
Bugpilot (Bug tracking)

Ok

THREATINT CVE Home CVE Diag Help
PUBLISHED

CVE-2024-26803

net: veth: clear GRO when clearing XDP even when down

Reserved:2024-02-19
Published:2024-04-04
Updated:2024-04-04

Description

In the Linux kernel, the following vulnerability has been resolved: net: veth: clear GRO when clearing XDP even when down veth sets NETIF_F_GRO automatically when XDP is enabled, because both features use the same NAPI machinery. The logic to clear NETIF_F_GRO sits in veth_disable_xdp() which is called both on ndo_stop and when XDP is turned off. To avoid the flag from being cleared when the device is brought down, the clearing is skipped when IFF_UP is not set. Bringing the device down should indeed not modify its features. Unfortunately, this means that clearing is also skipped when XDP is disabled _while_ the device is down. And there's nothing on the open path to bring the device features back into sync. IOW if user enables XDP, disables it and then brings the device up we'll end up with a stray GRO flag set but no NAPI instances. We don't depend on the GRO flag on the datapath, so the datapath won't crash. We will crash (or hang), however, next time features are sync'ed (either by user via ethtool or peer changing its config). The GRO flag will go away, and veth will try to disable the NAPIs. But the open path never created them since XDP was off, the GRO flag was a stray. If NAPI was initialized before we'll hang in napi_disable(). If it never was we'll crash trying to stop uninitialized hrtimer. Move the GRO flag updates to the XDP enable / disable paths, instead of mixing them with the ndo_open / ndo_close paths.

Product status

Default status
unaffected

d3256efd8e8b before f011c103e654
affected

d3256efd8e8b before 7985d73961bb
affected

d3256efd8e8b before 16edf51f33f5
affected

d3256efd8e8b before 8f7a3894e58e
affected

d3256efd8e8b before fe9f801355f0
affected

Default status
affected

5.13
affected

Any version before 5.13
unaffected

5.15.151
unaffected

6.1.81
unaffected

6.6.21
unaffected

6.7.9
unaffected

6.8
unaffected

References

https://git.kernel.org/stable/c/f011c103e654d83dc85f057a7d1bd0960d02831c

https://git.kernel.org/stable/c/7985d73961bbb4e726c1be7b9cd26becc7be8325

https://git.kernel.org/stable/c/16edf51f33f52dff70ed455bc40a6cc443c04664

https://git.kernel.org/stable/c/8f7a3894e58e6f5d5815533cfde60e3838947941

https://git.kernel.org/stable/c/fe9f801355f0b47668419f30f1fac1cf4539e736

cve.org CVE-2024-26803

nvd.nist.gov CVE-2024-26803

Download JSON

Share this page
https://cve.threatint.com/CVE/CVE-2024-26803